Changes to RSVP model#53
Conversation
- Add not null constraints to user_id and event_id - Replace date with accepted_at/declined_at - Fix whitespace
|
Good job! I only would like to discuss some case to you.
In this case we would have to filter by To keep the flexible that you have mentioned I think that would be more interesting replace Anyway, good job, I hope that my opinion was valuable. :) |
|
Thanks for the feedback! I guess it depends on what we're trying to achieve here. Do we care about the history of these RSVPs? As in if a user accepts now and declines later and vice versa. Currently we'd miss out on this info on top of not knowing whether someone declined or not. We're also constrained by the composite primary key of Perhaps we should store an enum |
|
Maybe the idea of use an enum could be a good approach. On my previous commentary I was thinking in get an ordered list of all users in waiting list. Because when someone that has accepted his invite to event decide does not go. Therefore, the first user on waiting list could be receive an invite. In resume I care about keep a ordered list to invite users in waiting list on the correct sequence. |
|
To be clear, do we intend to have waiting list functionality? For example, if a user tries to RSVP to an event that's full are we planning on adding them to a waiting list and contacting them if a spot is open as part of the MVP? |
|
@conr I really appreciate your work on this but we are keeping things simple with MVP. This is something we'll consider for post MVP release. I would encourage you to create an issue for this. I'll add it to the roadmap. :) Closing this since it's not MVP specific. |
datewithaccepted_at/declined_atI did not add not null constraints to
accepted_at/declined_atas we could potentially allow for invites, meaning we could have RSVPs without either in a pending state.Happy to hear people's thoughts on this one though.